AIMP DLNA v2.5.0.1 [AIMP4.50+]

[Zhenya]

There is a memory leak after the player is closed.



The log was obtained using this debug build:

https://yadi.sk/d/-Dacp9J83YuFWB

Also after restarting the player with active DLNA tab, the tree on the left becomes empty. You need to manually press F5 in the music library to get a content of the tree back.

[Moshi0]

There is a memory leak after the player is closed.

The log was obtained using this debug build:
Also after restarting the player with active DLNA tab, the tree on the left becomes empty. You need to manually press F5 in the music library to get a content of the tree back.

Yea, you have to manually refresh for now as I had problems with signalling aimp that the tree has changed.

About the memory leak, I honestly dont know how to find where I am leaking.

[Zhenya]

Yea, you have to manually refresh for now as I had problems with signalling aimp that the tree has changed.

Maybe MusicLibraryDemo (DemoExplorerView) from the SDK will help you?

[Moshi0]

Maybe MusicLibraryDemo (DemoExplorerView) from the SDK will help you?

Not really because its written in pascal not c++. There is no c++ examples of custom music library implementation as far as I can tell.
I managed to fix some memory leaks but I cant figure out the rest.

For example I commented almost all of the code but its still leaking memory on just plugin initialization:

Code: [Select]

A memory block has been leaked. The size is: 36

This block was allocated by thread 0x53C0, and the stack trace (return addresses) at the time was:
0176a1d8 +04 AIMP.Runtime.dll System       4755 +20 @GetMem
01249d6a +6e AIMP.Shared.dll  AIMP.Core     348  +3 TAIMPCore.RegisterExtension
012e37ef +63 AIMP.Shared.dll  AIMP.Plugins  657  +5 TAIMPPluginPresenter.RegisterExtension
012e2fab +5f AIMP.Shared.dll  AIMP.Plugins  461  +7 TAIMPPlugin.Initialize
012e4d47 +0f AIMP.Shared.dll  AIMP.Plugins 1000  +2 TAIMPPluginManager.Load

The block is currently used for an object of class: TAIMPMLGroupingPresetsAdapter
Even tho im not even using a IAIMPMLGroupingPresets.
It does not help that internal pascal function names are different from those in c++ sdk.

[Zhenya]

I think it remains only to hope for help from Artem.

[Moshi0]

There is a memory leak after the player is closed.

The log was obtained using this debug build:
Also after restarting the player with active DLNA tab, the tree on the left becomes empty. You need to manually press F5 in the music library to get a content of the tree back.

All memory leaks should be fixed.

[Soolo]

All memory leaks should be fixed.

v2.2.0.0
On this build: https://yadi.sk/d/-Dacp9J83YuFWB
After AIMP exit

[Moshi0]

v2.2.0.0
On this build: https://yadi.sk/d/-Dacp9J83YuFWB
After AIMP exit

Whoops. Fixed.

[Soolo]

Whoops. Fixed.

Cool!
v2.2.1.0
not always shows all servers
after installation of the plug-in - all servers are visible
after AIMP exit and run AIMP again - not all servers are visible
it occurs not always, but is frequent

>>>

[Moshi0]

Cool!
v2.2.1.0
not always shows all servers
after installation of the plug-in - all servers are visible
after AIMP exit and run AIMP again - not all servers are visible
it occurs not always, but is frequent

Yeah, so the reason is that I cant refresh the tree every time a server is found because that makes it very annoying (gui flash, tree collapses, can sometime cause noticeable delays). I also want to make the initial load as fast as possible.
To counter this the plugin refreshes the tree after the first server is found, which may cause some servers to not be included. But they should be still discovered and you can refresh the tree manually with F5 or right click and select refresh.

In v2.2.2.0 I added a 1s delay every time a new server is discovered. I think that should help.

[Soolo]

or right click and select refresh.

i have no this menu item

[Moshi0]

i have no this menu item

Hmm I remember there being a refresh item, maybe it was removed in some update.
I always use F5.

Did the 1s delay help?

[Soolo]

Did the 1s delay help?

yes
but on feelings it is a big delay
it is possible to make less

[Moshi0]

Oh, I now have the plugin page/card thingy. Nice!

yes
but on feelings it is a big delay
it is possible to make less

Ok, in the next update it will be smaller, maybe 0.25 or 0.5s.
I guess I'll make this configurable when I add configuration dialog.

[Moshi0]

yes
but on feelings it is a big delay
it is possible to make less

In v2.3.0.0 you can fine tune the values in configuration dialog.