YouTube plugin for AIMP

[dundee]

I have this doesn't happen, everything is fine. I tried on versions v4.11.1841 and v.4.12.1860 Beta.
What version of AIMP are you using?

I use version v4.11.1841 under Windows 10 64-bit.

[Zhenya]

I use version v4.11.1841 under Windows 10 64-bit.

I use Windows 8.1 32-bit.
May be the reason is a bitness of OS? Or Windows 10? It is necessary that anyone else checked it out.

[AdrianEddy]

New version:
- Bug fixes
- New languages (thanks prydespar and Sztewe!)

https://www.dropbox.com/s/3jv0zjv040draq5/aimp_YouTube_v1.0-RC2.zip?dl=1
https://drive.google.com/file/d/0B-f9jVoGmm7eWXVrZjFlZERwSWM/view?usp=sharing
http://eddy.cx/files/aimp_YouTube_v1.0-RC2.zip

AIMP crashes each time I try to add e.g. this https://www.youtube.com/playlist?list=PLg-tE9EpLV1hBCS1i5XJJuXdhtFqIkjhr or this https://www.youtube.com/playlist?list=PLg-tE9EpLV1idN2WT_JOO7je1RvgUcw8A link to playlist.

Works all good for me. Firewall or antivirus maybe?

To AdrianEddy.
Each time you apply the settings added new copies of commands in the list:

Fixed

Hello there, YouTube used to work perfectly for me... but now can't play any links anymore... neither the palylist neither new ones.. maybe some YT privacy update? Coud you update the plugin aswell? PLEASE!!!!

It works for me, did you try on another computer?

It is possible to implement the feature to add videos with timestamp (argument &t=xxx in URL) and playback starting from that time only?

I'm not sure if AIMP can handle streams starting in the middle, but I don't think so. One possible solution would be to load the whole video and then just seek to desired moment, but I don't know how practical that would be. I'll maybe investigate this later.

The plugin doesn't use the mechanism of autolocalization and applied it completely by myself.

This is not true, just check out the code.
The reason it doesn't update actions text is I just don't recreate all menus and actions on language change, you have to restart AIMP. But language is not something you change every day so it's not a big issue I think

[Artem]

New version:
- Bug fixes
- New languages (thanks prydespar and Sztewe!)

Hello,

Zhenya have found an issue with new version of plugin. Plugin leads to memory corruption in App when you trying to install it via the "install" command in plugins manager (introduced in v4.12). What happened in core? In this case, AIMP extracts the plugin from archive and fetches an information about it:
1. Gets the header via AIMPPluginGetHeader
2. Gets all required information from the header
3. Release the header. This step leads to memory corruption.

I have checked your code and looks like that plugin trying to release the resources that not be initialized because of IAIMPPlugin.Initialize was not called.

Code: [Select]

    ~Plugin() {
        if (!m_finalized)
            Finalize();

        m_instance = nullptr;
    }


HRESULT WINAPI Plugin::Finalize()
{
    Timer::StopAll();

    AimpMenu::Deinit();
    AimpHTTP::Deinit();
    Config::Deinit();

    ...

    Gdiplus::GdiplusShutdown(m_gdiplusToken);  <<<<<< I think that error is here
    m_finalized = true;
    return S_OK;
}


[AdrianEddy]

I have checked your code and looks like that plugin trying to release the resources that not be initialized because of IAIMPPlugin.Initialize was not called.

Code: [Select]

    Gdiplus::GdiplusShutdown(m_gdiplusToken);  <<<<<< I think that error is here


Right, sorry about that.
Try those:
http://eddy.cx/files/aimp_YouTube_v1.0-RC3.zip
http://eddy.cx/files/aimp_SoundCloud_v1.0-RC3.zip

[Zhenya]

Try those:

Now memory corruption doesn't exist. But there is a memory leak:



How to repeat:
1. Add any track from YouTube.
2. Enable playback of this track.
3. Close AIMP - a message appears about memory leaks.

[Zhenya]

If you don't start the playback of this track, it will be such a message:

[AdrianEddy]

Now memory corruption doesn't exist. But there is a memory leak:

Try with this version

[Zhenya]

Try with this version

Now, if you start the playback then it will be:



If you do not start playback, it will be this:

[AdrianEddy]

Now, if you start the playback then it will be:

If you do not start playback, it will be this:

You're right, should be fixed now:

http://eddy.cx/files/aimp_YouTube_v1.0-RC3.zip
http://eddy.cx/files/aimp_SoundCloud_v1.0-RC3.zip

[Zhenya]

You're right, should be fixed now:

This is fixed:

Now, if you start the playback then it will be:

But this remained:

If you do not start playback, it will be this:

[Napalllm]

У меня такой вопрос и проблема. У меня не играл саб при просмотре youtube установил плагин  этот и как я был рад саб в youtube и вк заработал,но вот опять вечером включил комп захожу на youtube а саб опят ьне звучит там. в чём может быть проблема подскажите? спасибо

[Zhenya]

...но вот опять вечером включил комп захожу на youtube а саб опят ьне звучит там...

Куда именно? На сайт Youtube?

У меня не играл саб при просмотре youtube установил плагин  этот и как я был рад саб в youtube и вк заработал

Тут же вы наверно через AIMP слушали звук с Youtube?

Плагин влияет только на AIMP, а не на браузер.

[Napalllm]

да это то и странно вычитал в вк один парень писал что установил плагин и у него youtube 5.1 был. ну я и попробовал удалил старый aimp3 поставил новую версию и плагин ну на youtube захожу включаю клипы и офигеваю саб работает. Но потом вынужден был отключить комп а когда включил уже этого прекрасного звука не было. Просто что только не делал нечего не помогало и браузеры менял и в конфиги лазил нечего не менялось только установил аимп и плагин и звук 5.1 появился. я пониамаю что плагин на аимп влияет но я заходил именно через браузер на youtube и звук был норм именно после установки хз что было(  может подскажите что может быть и как вернуть звук.

[martinco78]

Here is slovak translation