iPod Touch, iPad remote control)

[Artem]

I think, player may tries to download album art from the Internet, this operation is so slow.

[mmote]

Almost all files have embedded cover art, so I don't see why it should perform an online lookup. Something like AIMP_SERVICE_ALBUMART_FLAGS_OFFLINE would be handy, though.
I plugged in my own image loading code for now (takes less than 60ms on average).

[Artem]

Almost all files have embedded cover art, so I don't see why it should perform an online lookup. Something like AIMP_SERVICE_ALBUMART_FLAGS_OFFLINE would be handy, though.
I plugged in my own image loading code for now (takes less than 60ms on average).

I have implemented the AIMP_SERVICE_ALBUMART_FLAGS_OFFLINE, please try it on new build:
https://yadi.sk/d/ypjmP1YHgpNRBw
https://yadi.sk/d/g80ydFh-BU_LiA

Also, I have fixed fundamental issue with calling convention in the IAIMPTaskOwner.IsCanceled method. This method has used a __pascal calling convention which support has been removed in new versions of MS Visual Studio. So, that way you could get AV on calling this method if you plugin has been compiled with new studios.

[mmote]

Thanks. That flag doesn't do much in terms of speed, so I'll need to stick to my custom code for now. Maybe I'll use IAIMPServiceAlbumArt as a fallback only.

Other stuff I came across:
- Couldn't figure out how to use AIMPML_FILTER_SORTBY (not that important, though, I can easily sort the data myself)
- When retrieving data via IAIMPFileInfo, a bunch of exceptions appear to be thrown if the requested value does not exist. This makes playlist retrieval very slow and hard to test for me. Probably just an issue with the debug build?

Apart from that I've got most of the functionality working again. Have you got a release date in mind for the next update?

[Artem]

Thanks. That flag doesn't do much in terms of speed, so I'll need to stick to my custom code for now. Maybe I'll use IAIMPServiceAlbumArt as a fallback only.

Can you send to me an example or working assembly of plugin? I will check this issue using performance profiler.

- Couldn't figure out how to use AIMPML_FILTER_SORTBY (not that important, though, I can easily sort the data myself)

Now, just only one field can be defined in the AIMPML_FILTER_SORTBY property. So, it not so useful (I think).
But:
You must set to AIMPML_FILTER_SORTBY name of column (IAIMPString), additionally, set correct value to the AIMPML_FILTER_SORTDIRECTION property

... if the requested value does not exist.

Seems to be a bug. Can you explain in more details, how to reproduce it?

Apart from that I've got most of the functionality working again. Have you got a release date in mind for the next update?

I hope to release it in December.

[mmote]

Can you send to me an example or working assembly of plugin? I will check this issue using performance profiler.

Sure. Have you got a smartphone or tablet for testing? An iPad would be ideal.

You must set to AIMPML_FILTER_SORTBY name of column (IAIMPString), additionally, set correct value to the AIMPML_FILTER_SORTDIRECTION property

Ah, I didn't set AIMPML_FILTER_SORTBY...

Seems to be a bug. Can you explain in more details, how to reproduce it?

I'm retrieving info like this:

Code: [Select]

int32_t discCount;
if (SUCCEEDED(fileInfo->GetValueAsInt32(AIMP_FILEINFO_PROPID_DISKTOTAL, &discCount))) { ... }
where fileInfo is an IAIMPFileInfo instance I retrieved via AIMP_PLAYLISTITEM_PROPID_FILEINFO from an IAIMPPlaylistItem instance.
Whenever the property doesn't exist, two Delphi execptions (0x0EEDFADE) are thrown.

[Artem]

Sure. Have you got a smartphone or tablet for testing? An iPad would be ideal.

I have Android based devices.

where fileInfo is an IAIMPFileInfo instance I retrieved via AIMP_PLAYLISTITEM_PROPID_FILEINFO from an IAIMPPlaylistItem instance.
Whenever the property doesn't exist, two Delphi execptions (0x0EEDFADE) are thrown.

Looks like a bug, I will check it. Thank you.

[mmote]

I'll PM you.

[Artem]

I'll PM you.

Thank you.

[mmote]

v4.60 Build 2161 is working fine so far, but I think the exception issue I mentioned still exists. This causes very noticeable delays when trying to retrieve playlist contents, unfortunately. Would be great if that could be fixed, then I'm ready to officially release the AIMP 4 plugin.

[Artem]

Ok, I will check it

[Artem]

I have tried to reproduce it on latest nightly build using version of plugin that you send to me in PM, but failed. What I should do in the app to get the exception?

Here is a latest nightly build: https://yadi.sk/d/gYthLbJR39VTUA May be, this issue is already been fixed...

[mmote]

Exceptions are thrown when calling IAIMPFileInfo::GetValueAsInt32 for missing metadata.
I'm attaching an MP3 that you can use to reproduce the issue. Simply add it to the playlist, then connect with the app and switch to the playlist view.

[Artem]

Seems I have found an root of issue: note that the DISKNUMBER, DISKTOTAL, TRACKNUMBER and TRACKTOTAL are defined as strings, not as int32. Because, tracks may have letter-based numbering instead of numeric. Of course, API trying to covert value to asking format, but default value for these fields are an empty strings that cannot be converter to integer;

[mmote]

Ah, that makes sense. I'll try retrieving them as strings. Would be great if that could be documented in the SDK.